Enhance Task with a Runnable which will be run on the EDT after the task finishes
successfully and convert some users of org.gjt.sp.util.AwtRunnableQueue.runAfterIoTasks(Runnable)
to use this mechanism instead.
The idea is to get rid of the AwtRunnableQueue in the long term. And to couple the
Runnable which should be run after a background task finishes to the background task
itself.
Feedback is welcome on this idea.
Submitted | thomasmey - 2012-11-17 14:29:03 | Assigned | ezust |
---|---|---|---|
Priority | 5 | Labels | |
Status | pending | Group | None |
Resolution | invalid |
2012-11-17 14:29:04 thomasmey |
v1 Replace-WorkThreadPool-with-Executor-Framework-step4.patch (15.9Kio) |
---|---|
2012-12-12 21:01:18 ezust |
get rid of AwtRunnableQueue in the long term? It was just introduced. You should mark
it deprecated immediately if you want to remove it . Also XSearch will need to be
fixed again.
|
2012-12-28 10:47:29 thomasmey |
Hi Alan,
|
2012-12-28 17:53:23 ezust |
- **assigned_to**: nobody --> jarekczek |
2012-12-28 17:53:23 ezust |
I agree, the AwtRunnableQueue seems like something we really don't need in the API.
|
2013-02-07 00:40:22 ezust |
- **assigned_to**: jarekczek --> kpouer |
2013-02-07 09:07:42 kpouer |
I think the reason to have this AwtRunnableQueue is that in the first threadpool some
AWT tasks had to be done after all background tasks (the coupling was wrong but it
is not easy to take rid of it).
|
2013-03-16 18:44:26 ezust |
We should decide on what to do about this before releasing 5.1pre1, I think.
|
2013-04-07 11:55:51 thomasmey |
"When I wrote the threadpool I didn't use Swingworkers because I didn't find
|
2013-04-08 08:45:56 kpouer |
But in that case it would have the same behavior as we had before, when an AWT task is running, no other task can be started ? |
2013-04-13 11:25:16 thomasmey |
So some code, please have a look and tell me what do you think about the direction
this is heading\!
|
2013-04-13 11:25:46 thomasmey |
v1 |
2013-04-13 22:12:08 ezust |
so to clarify, do I need to apply 3 patches in this order to test this ticket?
|
2013-04-14 08:21:22 thomasmey |
Hi,
|
2013-04-15 17:19:05 ezust |
I don't know what ticket# the Fix-Hypersearch-Excessive-Mode-Usage.patch is in.
|
2013-04-15 18:38:25 thomasmey |
v2 - rebased against the new TaskManager-Refactor-ioTask.patch |
2013-04-15 18:40:09 thomasmey |
Hi,
|
2013-06-07 06:28:06 ezust |
- **assigned_to**: kpouer --> ezust |
2013-06-09 05:36:09 ezust |
I can apply the patch cleanly but I get a compile error on buffer.java:307 cannot
find symbol getIoTask()
|
2013-06-09 05:36:09 ezust |
- **status**: open --> open-remind |
2013-06-09 05:40:09 ezust |
- **status**: open-remind --> open |
2013-06-09 05:40:09 ezust |
Also, does the "Replace WorkThreadPool with Executor Framework.patch" - is that still
relevant? If so, then both patches need to be rebased.
|
2013-06-30 20:14:50 ezust |
- **status**: open --> pending-invalid |
2013-06-30 20:14:50 ezust |
Setting as invalid/pending until an updated patch is attached.
|