PreviousNextTracker indexSee it online !

(22/27) 578 - fix #2732 syntax highlighting broken if commenting starts in non-visible

This is a simple patch to invalidate (un)commented lines.
I'm not familiar with the TextArea code, si I'd appreciate a review.

line-comment is not affected, since its syntax highlighting is not context-sensitive so only visible lines need to be repainted, which is already done.

Fixes [#2732]

Submitted kerik-sf - 2015-11-14 13:48:56.362000 Assigned
Priority 5 Labels
Status pending Group
Resolution rejected

Comments

2015-11-14 14:54:30.499000
kerik-sf

- Description has changed:

Diff:

~~~~

--- old
+++ new
@@ -2,3 +2,5 @@
I'm not familiar with the TextArea code, si I'd appreciate a review.

line-comment is not affected, since its syntax highlighting is not context-sensitive so only visible lines need to be repainted, which is already done.
+
+Fixes [#2732]

~~~~

- **Group**: -->

2016-03-23 17:03:02.873000
marchaefner

This does not seem to solve the problem. The relevant lines are already invalidated as a result of the final `selectNone()` which calls `invalidateSelectedLines`. (But since you made me look into it there is now patch [#580])

2016-03-24 07:55:39.719000
kerik-sf

- **status**: open --> pending-rejected

2016-03-24 07:55:39.961000
kerik-sf

yes ideed, my patch doesn't seem to help.
yours (#580) seems to work.

Steps to reproduce:
1. open jEdit/build.xml
2. select from <project to </description
3. scroll down to hide <project but show </description
4. Edit > Code > Range comment
5. no syntax highlighting of the comment