PreviousNextTracker indexSee it online !

(298/301) 3533666 - XML: Completion popup for attributes after self-closed tag

Rev# 21773 contains a new test case for attribute completion.
Completion popups appear after a self-closed <tag/> when they should not.

The test case is: no popup should appear on line 24 of test_data/attributes_completion/attributes.xml,
and yet, one does.

Submitted ezust - 2012-06-08 - 22:52:32z Assigned kerik-sf
Priority 5 Category None
Status Pending Group None
Resolution Fixed Visibility No

Comments

2012-06-29 - 00:56:44z
ezust
Committed 21888.
2012-07-10 - 20:20:38z
kerik-sf
Alan, this fix prevents attribute completion when first attribute contains a '>' character (which is perfectly legal).
see test_data/attributes_completion/attributes.xml, line 26 @r21929
2012-08-03 - 05:09:08z
ezust
Can you please replace my one-liner almost-fix with something that works to your satisfaction?
Assigning ticket to you...
2012-08-26 - 15:52:02z
kerik-sf
r22073 contains a fix.
It's a big change, so may break other cases.
I leave the ticket open for now.


Except for comments,cdata and entities,
XmlParser checks for token types and image to guess completion mode required (element, attribute).

Two variants:
- strict, working only for html,xml,xsl,ant,maven,tld
- non strict, working with all of them + javadoc
Strict was made to prevent unwanted completions, but non strict
has more possibilities to adapt to other modes.

Non-strict is on by default.
If it works, it will stay so and strict mode will be removed.
One can switch between strict and non strict by setting the boolean
property "xml.try-modes-superset".
2012-09-16 - 20:52:14z
kerik-sf
works for me with the patch...

Attachments