A patch to add support for `<?xml-model>` processing instructions as a way to associate a RelaxNG schema
Submitted | conal_tuohy - 2019-12-03 04:44:57.435000 | Assigned | |
---|---|---|---|
Priority | 5 | Labels | XML RelaxNG |
Status | open | Group | None |
Resolution | None |
2019-12-03 04:46:36.109000 conal_tuohy |
Adding the XML plugin artifact as an attachment XML.jar (2.4Mio) |
---|---|
2019-12-08 18:10:19.480000 kerik-sf |
Thanks for the patch.
|
2019-12-09 04:40:58.470000 conal_tuohy |
Documentation:
|
2019-12-09 09:42:12.035000 conal_tuohy |
Regarding the code:
XML.diff (10.6Kio) |
2019-12-09 10:15:55.015000 kerik-sf |
1.1 I would also prioritize RelaxNG. In fact, I don't ask you to implement Schematron
at all if you don't need it ;-) What I don't understand is that you match on "http://purl.oclc.org/dsdl/schematron"
not "http://relaxng.org/ns/structure/1.0".
|
2019-12-09 11:13:25.687000 ezust |
I just want to say, reading this thread and seeing you help each other, alternate (231B) |
2019-12-09 11:56:41.981000 conal_tuohy |
Thanks very much for spotting the namespace confusion, Eric!
XML.diff (10.8Kio) |
2019-12-09 12:21:33.671000 kerik-sf |
Cool! Now I've only one request: put curly braces around cases in getPseudoAttributeValue
because it's such a common error to add another indented line to the last case and
think that it only applies in it, but it doesn't : it always applies. Or for short
code you can put it on the same line as the `if`. Then braces are not necessary.
|
2019-12-09 13:38:20.815000 conal_tuohy |
OK I have chosen to use curly braces in all cases, even where the `append` call is
short enough that it would have fitted on one line; I think the consistency makes
the method more readable.
XML.diff (10.8Kio) |
2019-12-09 13:48:30.341000 kerik-sf |
That's fine :-) |